Fix Repository __getitem__ consistency with __contains__#180
Open
sebPhilippot wants to merge 1 commit intoHBNetwork:masterfrom
Open
Fix Repository __getitem__ consistency with __contains__#180sebPhilippot wants to merge 1 commit intoHBNetwork:masterfrom
sebPhilippot wants to merge 1 commit intoHBNetwork:masterfrom
Conversation
lucasrcezimbra
requested changes
Aug 25, 2025
Member
lucasrcezimbra
left a comment
lucasrcezimbra
left a comment
There was a problem hiding this comment.
What are you trying to fix here? Can you explain and add test cases?
Author
|
The goal of my change (for issue #176) was to make the Repository classes consistent: if contains returns True because the key is present in os.environ, then getitem should also read from os.environ. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.